Issue 44 resolved #48
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for laptops as well as mobiles co-authored-by: Dhruv <[email protected]> co-authored-by: Tanish <[email protected]> co-authored-by: Vidhita <[email protected]>
There was a problem hiding this comment.
I think this is a part of #42 and someone else is working on it.
There was a problem hiding this comment.
Why do we need this script? It is the same as run_local.sh right?
There was a problem hiding this comment.
Actually, there are some changes in this so kept I this file
There was a problem hiding this comment.
Changing the ports here breaks the application when we run it locally. The login/signup routes (USERS_URL) gives "not found" error and ATM_URL gives "cannot fetch" error. So please don't change the ports here.
|
Hey! @vatsalshah041 Thank you for the PR. I have reviewed the commits and left a few comments. In general, I think there are 2 main issues:
Can you please have a look at those? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please provide a meaningful description of what this change will do, or is for. Bonus points for including links to
related issues, other PRs, or technical references.
Note that by not including a description, you are asking reviewers to do extra work to understand the context of this
change, which may lead to your PR taking much longer to review, or result in it not being reviewed at all.
Type of Change
Checklist